fix: Modify package publishing to fix slack msg & publish_packages (#…#26825
fix: Modify package publishing to fix slack msg & publish_packages (#…#26825
Conversation
| to: s3://dl.influxdata.com/influxdb/releases/<< pipeline.git.tag >> | ||
|
|
||
| to: s3://dl.influxdata.com/influxdb/releases/ |
There was a problem hiding this comment.
I though we wanted to publish under the release tag subdirectories? It looks master is currently doing that: https://github.com/influxdata/plutonium/blame/e6f017b05c0fedce52d30eeed2eadd3b1b59137c/.circleci/config.yml#L358
There was a problem hiding this comment.
Let me check the commit history for the future commits after this one to see where and if we revert this to use the sub dir.
There was a problem hiding this comment.
Just noticed I was looking at the plutonium repo. However, weren't we going for putting releases into subdirectories?
There was a problem hiding this comment.
Yeah it looks like this was changed back to not use the sub-directory anymore in this commit. I'm going to create a separate PR for this #26827 to revert. That way the commit history can remain the same making it easier to reason about during cherry picking. @gwossum if you could please review the PR I linked here that would be great.
gwossum
left a comment
There was a problem hiding this comment.
LGTM, provided we make sure we fix the URL we're publishing the packages to
…26279)
(cherry picked from commit 8358f1b)