feat: Add --azure-endpoint argument to the CLI#26687
Merged
Conversation
This commit allows users to specify the endpoint that they want when using Azure for blob storage. We also automatically enable the allow http flag so that they can specify localhost as their URL if using something like Azurite to test Azure Blob Storage locally. Closes #26390
Contributor
|
Why do we automatically enable the allow http flag? I feel that should be more of a docs info on configuration rather than something we automatically apply. Perhaps we should instead follow the AWS pattern and have a |
waynr
reviewed
Aug 11, 2025
| builder = builder.with_access_key(key); | ||
| } | ||
| if let Some(endpoint) = &self.azure_endpoint { | ||
| builder = builder.with_allow_http(true); |
Contributor
There was a problem hiding this comment.
I agree with @peterbarnett03 on this, the user should be able to pass a flag that sets the allow http flag.
9a77aeb to
e0be403
Compare
e0be403 to
9dd0678
Compare
Contributor
Author
|
Moved it to it's own flag. I had it as a convenience thing, but I think on further reflection that it's best to make it it's own flag. |
waynr
approved these changes
Aug 20, 2025
Contributor
|
🎉 this will need to get ported to enterprise before 3.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows users to specify the endpoint that they want when using Azure for blob storage. We also automatically enable the allow http flag so that they can specify localhost as their URL if using something like Azurite to test Azure Blob Storage locally.
Closes #26390