fix: validate tag and field names when creating tables#26641
Merged
Conversation
Add validation to ensure tag and field names follow line protocol rules when creating tables via the catalog API. This prevents creating tables with invalid column names that would be rejected by the line protocol parser. The validation checks that tag and field names: - Are not empty - Do not contain spaces - Do not contain commas - Do not contain equals signs Closes #26486
Add unit tests using rstest to verify that the create_table method properly validates tag and field names according to line protocol rules. The tests cover: - Invalid cases: empty names - Valid cases: simple names, underscores, numbers, and mixed alphanumeric - Valid cases with escapes - Verification that tables are created correctly with valid names This ensures the validation added in the previous commit works as expected.
660e397 to
e24b4a6
Compare
a8ad3c0 to
e83a857
Compare
e83a857 to
cac9f8c
Compare
pauldix
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds validation to reject empty tag and field names, or those containing control characters when creating tables via the catalog API, ensuring compatibility with the line protocol parser.
Changes
Validation logic
Added
validate_key()function ininfluxdb3_catalog/src/catalog/update.rsthat rejects:Test coverage:
rstestfor various invalid cases (empty strings, newlines, tabs, etc.)Notes
Fixes #26486