Merged
Conversation
This commit fixes queries that could come back as failures due to improperly quoted table names in queries. It also fixes issues in Enterprise where compaction would fail due to double escaped names. The fix is relatively simple: - Use the parse not from function for the Path type in the object_store crate - Quote escape table names in queries With these two changes the failing tests that Praveen made to hightlight the issue have been fixed. Co-authored-by: praveen-influx <pkumar@influxdata.com>
hiltontj
approved these changes
Jul 3, 2025
Contributor
hiltontj
left a comment
There was a problem hiding this comment.
I left https://github.com/influxdata/influxdb_pro/pull/993#pullrequestreview-2984539787 on the enterprise PR with a detailed explanation of my understanding, but more importantly, a case that I think needs to be tested/potentially fixed: the parquet cache. Specifically, parquet files that get cached in the query path.
That might be a tricky test to set up so can be left as follow-on work to this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes queries that could come back as failures due to improperly quoted table names in queries. It also fixes issues in Enterprise where compaction would fail due to double escaped names.
The fix is relatively simple:
With these two changes the failing tests that Praveen made to hightlight the issue have been fixed.