Merged
Conversation
This commit allows deleting (soft) a table. For an user, following command will allow soft deleting a table (bar) in db (foo) ``` influxdb3 table delete --dbname foo --table bar --host $host ``` - Added `soft_delete_table` to `DatabaseManager` trait, which already hosts `soft_delete_database` method. The code roughly follows the same flow as db delete. Although like db schema, it does clone on write because the reference is behind an Arc, `Arc::make_mut` is used in this change. - Moved db delete related cli parser under "manage" module that has both db and table delete functionality - Some minor tidyups (removing unused methods, renaming method so that the order in name matches actual return type eg. `table_id_and_schema`, should return (id, schema) and not (schema, id)) closes: #25561
hiltontj
approved these changes
Nov 21, 2024
Contributor
hiltontj
left a comment
There was a problem hiding this comment.
This is awesome work, LGTM. The DatabaseManager trait should make porting this up into pro much smoother.
| let deletion_time = Time::from_timestamp_nanos(deleted_table_defn.deletion_time); | ||
| let table_name = | ||
| make_new_name_using_deleted_time(&deleted_table_defn.table_name, deletion_time); | ||
| let new_table_def = Arc::make_mut(deleted_table); |
Contributor
There was a problem hiding this comment.
Nice use of Arc::make_mut
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows deleting (soft) a table. For an user, following command will allow soft deleting a table (bar) in db (foo)
soft_delete_tabletoDatabaseManagertrait, which already hostssoft_delete_databasemethod. The code roughly follows the same flow as db delete. Although like db schema, it does clone on write because the reference is behind an Arc,Arc::make_mutis used in this change.table_id_and_schema, should return (id, schema) and not (schema, id))closes: #25561