Skip to content

fix: do not rename files on mmap failure#25356

Merged
gwossum merged 1 commit into2.7from
gw_25337_take2
Sep 24, 2024
Merged

fix: do not rename files on mmap failure#25356
gwossum merged 1 commit into2.7from
gw_25337_take2

Conversation

@gwossum
Copy link
Copy Markdown
Member

@gwossum gwossum commented Sep 17, 2024

If NewTSMReader() fails because mmap fails, do not rename the file, because the error is probably
caused by vm.max_map_count being too low

Closes: #25351

(cherry picked from commit 5aff511)

If NewTSMReader() fails because mmap fails, do not
rename the file, because the error is probably
caused by vm.max_map_count being too low

Closes: #25351

(cherry picked from commit 5aff511)
@gwossum gwossum added area/tsm area/2.x OSS 2.0 related issues and PRs labels Sep 17, 2024
@gwossum gwossum self-assigned this Sep 17, 2024
@gwossum gwossum marked this pull request as ready for review September 17, 2024 22:06
Copy link
Copy Markdown
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwossum gwossum merged commit 93d6ffc into 2.7 Sep 24, 2024
@gwossum gwossum deleted the gw_25337_take2 branch September 26, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tsm area/2.x OSS 2.0 related issues and PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants