fix(tsi1/partition/test): fix data races in test code (#57)#25336
Merged
fix(tsi1/partition/test): fix data races in test code (#57)#25336
Conversation
* fix(tsi1/partition/test): fix data races in test code This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged. (cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)
39df135 to
e8a655b
Compare
gwossum
reviewed
Sep 16, 2024
|
|
||
| // Wait will block until all compactions are finished. | ||
| // Must only be called while they are disabled. | ||
| // must only be called while they are disabled. |
Member
There was a problem hiding this comment.
I think some search and replace for mu de-capitalized this must.
Author
There was a problem hiding this comment.
@gwossum --
@davidby-influx suggested some changes in #25338 so I'll make those changes and do must -> Must and cherry pick in to all branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged.
(cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)
Closes #
Describe your proposed changes here.