fix: Add locking during tsi iterator creation.#20008
Merged
benbjohnson merged 1 commit intomasterfrom Nov 12, 2020
Merged
Conversation
This commit fixes a locking issue that caused the `TestShard_WritePoints_FieldConflictConcurrent` test to fail.
stuartcarnie
approved these changes
Nov 12, 2020
Contributor
stuartcarnie
left a comment
There was a problem hiding this comment.
Awesome! This data race seems to have been cropping up a lot more in CI lately
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a locking issue that caused the
TestShard_WritePoints_FieldConflictConcurrenttest to fail.
Closes #19664
link to the PR (not the Issue)