fix: sort files for adjacency testing (#26816) (#26879)

devanbenz · davidby-influx · web-flow · commit 7f56ad35acfa · 2025-10-06T12:54:32.000-05:00
Co-authored-by: davidby-influx &lt;72418212+davidby-influx@users.noreply.github.com&gt;
diff --git a/tsdb/engine/tsm1/compact_property_test.go b/tsdb/engine/tsm1/compact_property_test.go
@@ -38,32 +38,31 @@ type fileInfo struct {
 // This rule is important to maintain the ordering of files, with improper ordering we cannot determine which point is the newest point when overwrites occur.
 // We always want the newest write to win.
 func validateFileAdjacency(allFiles []string, groups []tsm1.CompactionGroup) error {
-	var fileInfos []fileInfo
+	fileInfos := make([]*fileInfo, 0, len(allFiles))
 	for _, file := range allFiles {
 		gen, seq, err := tsm1.DefaultParseFileName(file)
 		if err != nil {
 			return fmt.Errorf("failed to parse file %s: %v", file, err)
 		}
-		fileInfos = append(fileInfos, fileInfo{
+		fileInfos = append(fileInfos, &fileInfo{
 			filename:   file,
 			generation: gen,
 			sequence:   seq,
 		})
 	}
 
-	slices.SortFunc(fileInfos, func(a, b fileInfo) int {
+	slices.SortFunc(fileInfos, func(a, b *fileInfo) int {
 		if a.generation != b.generation {
 			return a.generation - b.generation
 		}
 
 		return a.sequence - b.sequence
 	})
 
-	var fileMap = make(map[string]fileInfo, len(allFiles))
-	for i, file := range allFiles {
-		fileMap[file] = fileInfo{
-			index: i,
-		}
+	var fileMap = make(map[string]*fileInfo, len(fileInfos))
+	for i, fi := range fileInfos {
+		fi.index = i
+		fileMap[fi.filename] = fi
 	}
 
 	for groupIndex, group := range groups {
