Skip to content

feat: add --pid-file and --overwrite-pid-file#5662

Merged
sanderson merged 3 commits intoinfluxdb-2.7.11from
gw-oss-2.7.11-pidfile
Nov 4, 2024
Merged

feat: add --pid-file and --overwrite-pid-file#5662
sanderson merged 3 commits intoinfluxdb-2.7.11from
gw-oss-2.7.11-pidfile

Conversation

@gwossum
Copy link
Copy Markdown
Member

@gwossum gwossum commented Oct 29, 2024

Add documentation related to PID file.

These options will be available starting in OSS 2.7.11.

Add documentation related to PID file.
Fix quoting in `pid-file` config examples.
@gwossum
Copy link
Copy Markdown
Member Author

gwossum commented Oct 29, 2024

PR implementing feature in OSS: influxdata/influxdb#25474

Copy link
Copy Markdown
Collaborator

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @gwossum! Could you add these new flags to the yaml file data/influxd_flags.yml as well? We use this file to generate a list of flags on the influxd landing page.

Also, when are we looking to release 2.7.11?

@gwossum
Copy link
Copy Markdown
Member Author

gwossum commented Oct 30, 2024

@sanderson The plan was to release this in 2.7.11. I noticed that influxd_flags.yml only lists major and minor for when flags were added. Is it terrible to add this new flag on a patch release, even if it is primarily for a single use-case?

@sanderson
Copy link
Copy Markdown
Collaborator

@gwossum

I noticed that influxd_flags.yml only lists major and minor for when flags were added.

This data file was originally added when we were documenting each minor version in the versions specified in the influxd_flags.yml were used to filter flags based on the current minor version. We no longer document each minor version so this property is essentially obsolete. You can just put 2.7. It won't make a difference.

Is it terrible to add this new flag on a patch release, even if it is primarily for a single use-case?

Generally this would be considered a "new feature" and would be added on a minor release, but I think it's fine. I don't think this needs to wait until 2.8.

Update influxd_flags.yml to include `--overwrite-pid-file` and `--pid-file`.
@gwossum
Copy link
Copy Markdown
Member Author

gwossum commented Oct 30, 2024

@sanderson influxd-flags.yml has been updated.

@sanderson sanderson changed the base branch from master to influxdb-2.7.11 October 30, 2024 21:00
Copy link
Copy Markdown
Collaborator

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gwossum. I added a new influxdb-2.7.11 feature branch and changed the base on this PR from master to that branch. That way we can merge this PR, but release all the 2.7.11 features and release notes when it goes live.

@sanderson sanderson merged commit 8b73de9 into influxdb-2.7.11 Nov 4, 2024
@sanderson sanderson deleted the gw-oss-2.7.11-pidfile branch November 4, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants