Skip to content

feat: return sub-exts when extension type exts themselves are matched#928

Merged
ayangweb merged 1 commit intomainfrom
search_ext_container
Oct 19, 2025
Merged

feat: return sub-exts when extension type exts themselves are matched#928
ayangweb merged 1 commit intomainfrom
search_ext_container

Conversation

@SteveLauC
Copy link
Copy Markdown
Member

Take the 'Spotify Control' extension as an example:

  • Spotify Control
    • Toggle Play/Pause
    • Next Track
    • Previous Track

Previously, these sub-extensions were only returned when the query string matched them, and thus counterintuitively, searching for 'Spotify Control' would not hit them.

This commit changes that behavior: when a main extension (of type Extension) matches the query, all of its sub-extensions are now included in the results.

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

Take the 'Spotify Control' extension as an example:

- Spotify Control
  - Toggle Play/Pause
  - Next Track
  - Previous Track

Previously, these sub-extensions were only returned when the query string
matched them, and thus counterintuitively, searching for 'Spotify Control' would
not hit them.

This commit changes that behavior: when a main extension (of type Extension)
matches the query, all of its sub-extensions are now included in the results.
@SteveLauC SteveLauC force-pushed the search_ext_container branch from ef9c650 to 823fd29 Compare October 15, 2025 08:43
@ayangweb ayangweb merged commit cd00ada into main Oct 19, 2025
4 checks passed
@ayangweb ayangweb deleted the search_ext_container branch October 19, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants