fix(Window Management): Next/Previous Desktop do not work#926
Merged
Conversation
This commit fixes the issue that when the current desktop contains more than 1 windows, moving the focused window via `NextDesktop` and `PreviousDesktop` won't work. How? By adding 2 missing `sleep()` functions: 1. https://github.com/ianyh/Silica/blob/b91a18dbb822e99ce6b487d1cb4841e863139b2a/Silica/Sources/SIWindow.m#L242 2. https://github.com/ianyh/Silica/blob/b91a18dbb822e99ce6b487d1cb4841e863139b2a/Silica/Sources/SIWindow.m#L249 Also, this commit improves the implementation by resetting the mouse position. `NextDesktop` and `PreviousDesktop` are implemented by emulating mouse and keyboard events, draging the focused window and switching to the corresponding desktop. To make a window draggable, we have to move the mouse to the window's traffic light area. It is disturbing to not move the mouse back so this commit implements it.
ayangweb
approved these changes
Oct 14, 2025
medcl
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue that when the current desktop contains more than 1 windows, moving the focused window via
NextDesktopandPreviousDesktopwon't work.How? By adding 2 missing
sleep()functions:Also, this commit improves the implementation by resetting the mouse position.
NextDesktopandPreviousDesktopare implemented by emulating mouse and keyboard events, draging the focused window and switching to the corresponding desktop. To make a window draggable, we have to move the mouse to the window's traffic light area. It is disturbing to not move the mouse back so this commit implements it.Standards checklist