Skip to content

fix: ensure search paths are indexed#896

Merged
ayangweb merged 1 commit intomainfrom
feat/index_search_paths
Sep 22, 2025
Merged

fix: ensure search paths are indexed#896
ayangweb merged 1 commit intomainfrom
feat/index_search_paths

Conversation

@SteveLauC
Copy link
Copy Markdown
Member

@SteveLauC SteveLauC commented Sep 18, 2025

The file search extension relies on the OS's desktop search to work, and it
is possible that the desktop search indexer may not index the search paths
we specify.

This commit adds a hook that signals to the indexer and lets it index
the paths we need. This hook will be invoked when:

  • initialing the extension
  • enabling the extension
  • upon every configuration change

to make our best effort to fix the issue.

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@SteveLauC SteveLauC force-pushed the feat/index_search_paths branch from 6fec385 to aea9fd1 Compare September 18, 2025 11:18
@SteveLauC SteveLauC changed the title bindgen searchapi.h && add a hook for file search config update feat: ensure search paths will be indexed (on Windows) Sep 18, 2025
@SteveLauC SteveLauC changed the title feat: ensure search paths will be indexed (on Windows) fix: ensure search paths will be indexed (on Windows) Sep 18, 2025
@SteveLauC SteveLauC force-pushed the feat/index_search_paths branch from dd312cd to c7276a3 Compare September 18, 2025 11:20
@SteveLauC SteveLauC marked this pull request as ready for review September 18, 2025 11:20
@SteveLauC SteveLauC marked this pull request as draft September 19, 2025 08:21
@SteveLauC SteveLauC force-pushed the feat/index_search_paths branch 2 times, most recently from 31a82d0 to f5659df Compare September 21, 2025 04:29
@SteveLauC SteveLauC changed the title fix: ensure search paths will be indexed (on Windows) fix: ensure search paths will be indexed Sep 21, 2025
@SteveLauC SteveLauC force-pushed the feat/index_search_paths branch 2 times, most recently from fe97148 to 6ba3b38 Compare September 22, 2025 06:48
@SteveLauC SteveLauC changed the title fix: ensure search paths will be indexed fix: ensure search paths are indexed Sep 22, 2025
The file search extension relies on the OS's desktop search to work, and it
is possible that the desktop search indexer may not index the search paths
we specify.

This commit adds a hook that signals to the indexer and lets it index
the paths we need. This hook will be invoked when:

* initialing the extension
* enabling the extension
* upon every configuration change

to make our best effort to fix the issue.
@SteveLauC SteveLauC force-pushed the feat/index_search_paths branch from 6ba3b38 to f229c47 Compare September 22, 2025 06:49
@SteveLauC SteveLauC marked this pull request as ready for review September 22, 2025 06:50
@ayangweb ayangweb merged commit 450bacc into main Sep 22, 2025
4 checks passed
@ayangweb ayangweb deleted the feat/index_search_paths branch September 22, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants