fix: use kill_on_drop() to avoid zombie proc in error case#887
Merged
fix: use kill_on_drop() to avoid zombie proc in error case#887
Conversation
In the previous macOS file search implementation, we spawned an mdfind child process and killed it when we got the results we needed to avoid zombie processes. However, this kill step would be skipped if an error happened during query results processing as we propagate errors. This commit replaces the manual kill operation with the `ChildProcHandle.kill_on_drop()` API to let RAII do the job to fix the issue.
medcl
approved these changes
Aug 26, 2025
ayangweb
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous macOS file search implementation, we spawned an mdfind child process and killed it when we got the results we needed to avoid zombie processes. However, this kill step would be skipped if an error happened during query results processing as we propagate errors.
This commit replaces the manual kill operation with the
ChildProcHandle.kill_on_drop()API to let RAII do the job to fix the issue.Standards checklist