Merged
Conversation
d5e2ffc to
18950c3
Compare
This commit implements the file search extension for Linux with the GNOME desktop environment by employing the engine that powers GNOME's desktop search - Tracker. It also fixes an edge case bug that the search and exclude path configuration entries will not work. For example, say I set the search path to ["~/Dcouments"], and I have a file named "Documents_foobarbuzz" under my home directory, this file is not in the specified search path but Coco would return it because we verified this by checking string prefix. Claude Code found this when I asked it to write unit tests. Thank both tests and Claude Code.
9616e4a to
08fff67
Compare
medcl
reviewed
Aug 25, 2025
| } | ||
|
|
||
| impl Query { | ||
| fn new(query_string: &str, config: &FileSearchConfig) -> Result<Self, String> { |
Member
There was a problem hiding this comment.
Did you check the feature availability before initializing the actual service? if it is not gnome or other requirements
not ready, we should skip it.
medcl
approved these changes
Aug 25, 2025
Member
medcl
left a comment
There was a problem hiding this comment.
LGTM, as we only support Ubuntu platform only right now
ayangweb
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the file search extension for Linux with the
GNOME desktop environment by employing the engine that powers GNOME's
desktop search - Tracker.
It also fixes an edge case bug that the search and exclude path
configuration entries will not work. For example, say I set the search path
to ["~/Documents"], and I have a file named "Documents_foobarbuzz" under
my home directory, this file is not in the specified search path but
Coco would return it because we verified this by checking string prefix.
Claude Code found this when I asked it to write unit tests. Thank both
tests and Claude Code.
Standards checklist