Skip to content

fix: set up hotkey on main thread or Windows will complain#879

Merged
RainyNight9 merged 1 commit intomainfrom
fix/set_up_hotkey_in_main_thread
Aug 20, 2025
Merged

fix: set up hotkey on main thread or Windows will complain#879
RainyNight9 merged 1 commit intomainfrom
fix/set_up_hotkey_in_main_thread

Conversation

@SteveLauC
Copy link
Copy Markdown
Member

Coco panicked on Windows when I was testing the applications-rs crate on Windows, the error message seemingly indicates that we should run hotkey setup on the main thread, and doing that indeed fixes the issue, so let's do it.

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

Coco panicked on Windows when I was testing the applications-rs crate on
Windows, the error message seemingly indicates that we should run hotkey setup
on the main thread, and doing that indeed fixes the issue, so let's do
it.
@RainyNight9 RainyNight9 merged commit 828c847 into main Aug 20, 2025
4 checks passed
@RainyNight9 RainyNight9 deleted the fix/set_up_hotkey_in_main_thread branch August 20, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants