fix: panic on Ubuntu (GNOME) when opening apps#821
Merged
Conversation
On Ubuntu (the GNOME version), Coco would panic when users open an app due to the reason that Coco thinks it is running in an unsupported desktop environment (DE). We rely on the environment variable XDG_CURRENT_DESKTOP to detect the DE, Ubuntu sets this variable to "ubuntu:GNOME" instead of just "GNOME", which was not handled by the previous implementation. This commit supports this case. Also, when Coco runs in an unsupported DE, opening apps should not panic the app. After this commit, we would return an error.
luohoufu
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Ubuntu (the GNOME version), Coco would panic when users open an app due to the reason that Coco thinks it is running in an unsupported desktop environment (DE).
We rely on the environment variable XDG_CURRENT_DESKTOP to detect the DE, Ubuntu sets this variable to "ubuntu:GNOME" instead of just "GNOME", which was not handled by the previous implementation.
This commit supports this case. Also, when Coco runs in an unsupported DE, opening apps should not panic the app. After this commit, we would return an error.
What does this PR do
Rationale for this change
Standards checklist