fix(file search): apply filters before from/size parameters#741
Merged
Conversation
236fe0b to
29dc12f
Compare
6e74cc0 to
bb58b16
Compare
medcl
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Before this PR, the from/size pagination parameters were applied before filtering, which could lead to incorrect query results in certain cases.
For example, suppose there are 10 files in total, and the first 5 do not match the filter criteria. If the query uses from = 0 and size = 5, applying pagination before filtering would select the first 5 files, all of which would then be filtered out — resulting in an empty result set, even though 5 matching files do exist.
This PR fixes the issue by ensuring that filters are applied first, and then pagination (from and size) is applied to the filtered results.
Rationale for this change
Standards checklist