fix: do not pass whitespace-only strings to Calculator expr evaluation lib#532
Merged
RainyNight9 merged 1 commit intomainfrom May 19, 2025
Merged
fix: do not pass whitespace-only strings to Calculator expr evaluation lib#532RainyNight9 merged 1 commit intomainfrom
RainyNight9 merged 1 commit intomainfrom
Conversation
RainyNight9
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
The math expression evaluation library we use will panic if the passed query string is a string with only whitespace. After this PR, we no longer pass such strings to it.
Rationale for this change
Standards checklist