revert: Document constructor changed in #399#410
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previously introduced changes to the Document constructor from PR #399. The changes update how Document instances are constructed in multiple modules.
- In CalculatorSource, the instantiation has been changed from using Document::new(Document { … }) to directly constructing a Document using a struct literal.
- In ApplicationSearchSource, the constructor now calls Document::new with a new signature accepting separate parameters, reverting the previous pattern.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src-tauri/src/local/calculator.rs | Reverts Document instantiation to a struct literal in CalculatorSource. |
| src-tauri/src/local/application.rs | Reverts the Document constructor usage by invoking Document::new with separate parameters. |
| src-tauri/src/common/document.rs | Updates Document::new to a multi-parameter signature for constructing Document. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Revert the change to
Document::new()in introduced in PR #399Rationale for this change
Standards checklist