fix: filter http query_args and convert only supported values (#394)

medcl · web-flow · commit e8d197fb3294 · 2025-04-19T09:59:24.000+08:00
diff --git a/docs/content.en/docs/release-notes/_index.md b/docs/content.en/docs/release-notes/_index.md
@@ -31,6 +31,7 @@ Information about release notes of Coco Server is provided here.
 - fix: active shadow setting #354
 - fix: chat history was not show up #377
 - fix: get attachments in chat sessioins
+- fix: filter http query_args and convert only supported values
 
 ### Improvements
 
diff --git a/src-tauri/src/server/http_client.rs b/src-tauri/src/server/http_client.rs
@@ -82,8 +82,23 @@ impl HttpClient {
         }
 
         if let Some(query) = query_params {
-            let query: HashMap<String, String> =
-                query.into_iter().map(|(k, v)| (k, v.to_string())).collect();
+            // Convert only supported value types into strings
+            let query: HashMap<String, String> = query
+                .into_iter()
+                .filter_map(|(k, v)| {
+                    match v {
+                        JsonValue::String(s) => Some((k, s)),
+                        JsonValue::Number(n) => Some((k, n.to_string())),
+                        JsonValue::Bool(b) => Some((k, b.to_string())),
+                        _ => {
+                            dbg!(
+                                "Unsupported query parameter type. Only strings, numbers, and booleans are supported.",k,v,
+                            );
+                            None
+                        } // skip arrays, objects, nulls
+                    }
+                })
+                .collect();
             request_builder = request_builder.query(&query);
         }
 
@@ -169,7 +184,7 @@ impl HttpClient {
             query_params,
             body,
         )
-        .await
+            .await
     }
 
     // Convenience method for PUT requests
@@ -189,7 +204,7 @@ impl HttpClient {
             query_params,
             body,
         )
-        .await
+            .await
     }
 
     // Convenience method for DELETE requests
@@ -208,6 +223,6 @@ impl HttpClient {
             query_params,
             None,
         )
-        .await
+            .await
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -82,8 +82,23 @@ impl HttpClient {`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`if let Some(query) = query_params {`
`85`		`- let query: HashMap<String, String> =`
`86`		`- query.into_iter().map(\|(k, v)\| (k, v.to_string())).collect();`
	`85`	`+ // Convert only supported value types into strings`
	`86`	`+ let query: HashMap<String, String> = query`
	`87`	`+ .into_iter()`
	`88`	`+ .filter_map(\|(k, v)\| {`
	`89`	`+ match v {`
	`90`	`+ JsonValue::String(s) => Some((k, s)),`
	`91`	`+ JsonValue::Number(n) => Some((k, n.to_string())),`
	`92`	`+ JsonValue::Bool(b) => Some((k, b.to_string())),`
	`93`	`+ _ => {`
	`94`	`+ dbg!(`
	`95`	`+ "Unsupported query parameter type. Only strings, numbers, and booleans are supported.",k,v,`
	`96`	`+ );`
	`97`	`+ None`
	`98`	`+ } // skip arrays, objects, nulls`
	`99`	`+ }`
	`100`	`+ })`
	`101`	`+ .collect();`
`87`	`102`	`request_builder = request_builder.query(&query);`
`88`	`103`	`}`
`89`	`104`
`@@ -169,7 +184,7 @@ impl HttpClient {`
`169`	`184`	`query_params,`
`170`	`185`	`body,`
`171`	`186`	`)`
`172`		`- .await`
	`187`	`+ .await`
`173`	`188`	`}`
`174`	`189`
`175`	`190`	`// Convenience method for PUT requests`
`@@ -189,7 +204,7 @@ impl HttpClient {`
`189`	`204`	`query_params,`
`190`	`205`	`body,`
`191`	`206`	`)`
`192`		`- .await`
	`207`	`+ .await`
`193`	`208`	`}`
`194`	`209`
`195`	`210`	`// Convenience method for DELETE requests`
`@@ -208,6 +223,6 @@ impl HttpClient {`
`208`	`223`	`query_params,`
`209`	`224`	`None,`
`210`	`225`	`)`
`211`		`- .await`
	`226`	`+ .await`
`212`	`227`	`}`
`213`	`228`	`}`