fix: broken windows search (#801)

SteveLauC · web-flow · commit e78fe4ac89c9 · 2025-07-23T12:33:18.000+08:00
This commit fixes the search issue introduced by [commit](5c0a865). We have no idea why the tauri command `get_app_search_source` won't be invoked after that commit on Windows. This commit resolves the issue by moving the extension init logic to the Rust side. Also, update the querysource logs in `quey_coco_fusion()`, the old one won't say anything if the querysource list is empty, the new one will tell us that.
diff --git a/src-tauri/src/lib.rs b/src-tauri/src/lib.rs
@@ -198,6 +198,22 @@ pub fn run() {
 
             block_on(async {
                 init(app.handle()).await;
+
+                // We want all the extensions here, so no filter condition specified.
+                match extension::list_extensions(app_handle.clone(), None, None, false).await {
+                    Ok((_found_invalid_extensions, extensions)) => {
+                        // Initializing extension relies on SearchSourceRegistry, so this should
+                        // be executed after `app.manage(registry)`
+                        if let Err(e) =
+                            extension::init_extensions(app_handle.clone(), extensions).await
+                        {
+                            log::error!("initializing extensions failed with error [{}]", e);
+                        }
+                    }
+                    Err(e) => {
+                        log::error!("listing extensions failed with error [{}]", e);
+                    }
+                }
             });
 
             shortcut::enable_shortcut(app);
@@ -412,13 +428,6 @@ fn move_window_to_active_monitor<R: Runtime>(window: &WebviewWindow<R>) {
 
 #[tauri::command]
 async fn get_app_search_source(app_handle: AppHandle) -> Result<(), String> {
-    // We want all the extensions here, so no filter condition specified.
-    let (_found_invalid_extensions, extensions) =
-        extension::list_extensions(app_handle.clone(), None, None, false)
-            .await
-            .map_err(|e| e.to_string())?;
-    extension::init_extensions(app_handle.clone(), extensions).await?;
-
     let _ = server::connector::refresh_all_connectors(&app_handle).await;
     let _ = server::datasource::refresh_all_datasources(&app_handle).await;
 
diff --git a/src-tauri/src/search/mod.rs b/src-tauri/src/search/mod.rs
@@ -83,12 +83,22 @@ pub async fn query_coco_fusion(
     let timeout_duration = Duration::from_millis(query_timeout);
 
     log::debug!(
-        "{}(): {:?}, timeout: {:?}",
+        "{}() invoked with parameters: from: [{}], size: [{}], query_strings: [{:?}], timeout: [{:?}]",
         function_name!(),
+        from,
+        size,
         query_strings,
         timeout_duration
     );
 
+    log::debug!(
+        "will query querysources {:?}",
+        sources_list
+            .iter()
+            .map(|search_source| search_source.get_type().id.clone())
+            .collect::<Vec<String>>()
+    );
+
     let search_query = SearchQuery::new(from, size, query_strings.clone());
 
     if let Some(query_source_id) = opt_query_source_id {
@@ -135,7 +145,6 @@ pub async fn query_coco_fusion(
     } else {
         for query_source_trait_object in sources_list {
             let query_source = query_source_trait_object.get_type().clone();
-            log::debug!("will query querysource [{}]", query_source.id);
             futures.push(same_type_futures(
                 query_source,
                 query_source_trait_object,
diff --git a/src/commands/servers.ts b/src/commands/servers.ts
@@ -417,4 +417,4 @@ export const query_coco_fusion = (payload: {
 
 export const get_app_search_source = () => {
   return invokeWithErrorHandler<void>("get_app_search_source");
-};
+};
