fix: panic when fetching app metadata on Windows (#538)

SteveLauC · web-flow · commit 2b59addb08c0 · 2025-05-21T09:04:08.000+08:00
* fix: panic when fetching app metadata on Windows

* release note
diff --git a/docs/content.en/docs/release-notes/_index.md b/docs/content.en/docs/release-notes/_index.md
@@ -34,6 +34,7 @@ Information about release notes of Coco Server is provided here.
 - fix: loading chat history for potential empty attachments
 - fix: datasource & MCP list synchronization update #521
 - fix: show only enabled datasource & MCP list
+- fix: panic when fetching app metadata on Windows #538
 
 ### ✈️ Improvements
 
diff --git a/src-tauri/src/local/application/mod.rs b/src-tauri/src/local/application/mod.rs
@@ -12,7 +12,6 @@ pub use with_feature::*;
 #[cfg(not(feature = "use_pizza_engine"))]
 pub use without_feature::*;
 
-
 #[derive(Debug, Serialize, Clone)]
 #[serde(rename_all = "camelCase")]
 pub struct AppEntry {
@@ -24,15 +23,13 @@ pub struct AppEntry {
     is_disabled: bool,
 }
 
-
 #[derive(serde::Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct AppMetadata {
     name: String,
     r#where: String,
     size: u64,
-    icon: String,
     created: u128,
     modified: u128,
     last_opened: u128,
-}
+}
diff --git a/src-tauri/src/local/application/with_feature.rs b/src-tauri/src/local/application/with_feature.rs
@@ -117,10 +117,10 @@ fn get_app_path(app: &App) -> String {
 
 /// Helper function to return `app`'s path.
 ///
-/// * Windows/macOS: extract `app_path`'s file name and remove the file extension
-/// * Linux: return the name specified in `.desktop` file
+/// * macOS: extract `app_path`'s file name and remove the file extension
+/// * Windows/Linux: return the name specified in `.desktop` file
 async fn get_app_name(app: &App) -> String {
-    if cfg!(target_os = "linux") {
+    if cfg!(any(target_os = "linux", target_os = "windows")) {
         app.name.clone()
     } else {
         let app_path = get_app_path(app);
@@ -1074,15 +1074,7 @@ pub async fn get_app_list<R: Runtime>(
 }
 
 #[tauri::command]
-pub async fn get_app_metadata<R: Runtime>(
-    tauri_app_handle: AppHandle<R>,
-    app_path: String,
-) -> Result<AppMetadata, String> {
-    let app =
-        App::from_path(std::path::Path::new(&app_path)).expect("frontend sends an invalid app");
-
-    let app_path = get_app_path(&app);
-    let app_name = get_app_name(&app).await;
+pub async fn get_app_metadata(app_name: String, app_path: String) -> Result<AppMetadata, String> {
     let app_path_where = {
         let app_path_borrowed_path = std::path::Path::new(app_path.as_str());
         let app_path_where = app_path_borrowed_path
@@ -1094,11 +1086,13 @@ pub async fn get_app_metadata<R: Runtime>(
             .expect("it is guaranteed to be UTF-8 encoded")
             .to_string()
     };
-    let icon = get_app_icon_path(&tauri_app_handle, &app).await?;
 
-    let raw_app_metadata = metadata(app_path.into(), None).await?;
+    let raw_app_metadata = metadata(app_path.clone().into(), None).await?;
+
+    let last_opened = if cfg!(target_os = "macos") {
+        let app = App::from_path(std::path::Path::new(&app_path))
+            .unwrap_or_else(|e| panic!("App::from_path({}) failed due to error '{}'", app_path, e));
 
-    let last_opened = if cfg!(any(target_os = "macos", target_os = "windows")) {
         let app_exe_path = app
             .app_path_exe
             .as_ref()
@@ -1114,7 +1108,6 @@ pub async fn get_app_metadata<R: Runtime>(
         name: app_name,
         r#where: app_path_where,
         size: raw_app_metadata.size,
-        icon,
         created: raw_app_metadata.created_at,
         modified: raw_app_metadata.modified_at,
         last_opened,
diff --git a/src/components/Settings/Extensions/components/Details/Application/index.tsx b/src/components/Settings/Extensions/components/Details/Application/index.tsx
@@ -4,34 +4,59 @@ import dayjs from "dayjs";
 import { useTranslation } from "react-i18next";
 import { useAsyncEffect } from "ahooks";
 import platformAdapter from "@/utils/platformAdapter";
-import { ExtensionsContext } from "../../..";
+import { ExtensionsContext, Plugin, type ExtensionsContextType } from "../../../index";
 
 interface Metadata {
   name: string;
   where: string;
   size: number;
-  icon: string;
   created: number;
   modified: number;
   lastOpened: number;
 }
 
 const App = () => {
   const { t } = useTranslation();
-  const { activeId } = useContext(ExtensionsContext);
+  const { activeId, plugins } = useContext(ExtensionsContext) as ExtensionsContextType;
 
   const [appMetadata, setAppMetadata] = useState<Metadata>();
 
+  const findPlugin = (plugins: Plugin[], id: string) => {
+    for (const plugin of plugins) {
+      const { children = [] } = plugin;
+
+      if (plugin.id === id) {
+        return plugin;
+      }
+
+      if (children.length > 0) {
+        const matched = findPlugin(children, id) as Plugin;
+
+        if (!matched) continue;
+
+        return matched;
+      }
+    }
+  };
+
+  const currentPlugin = useMemo(() => {
+    if (!activeId) return;
+    return findPlugin(plugins, activeId);
+  }, [activeId, plugins]);
+
   useAsyncEffect(async () => {
+    if (!activeId || !currentPlugin) return;
+
     const appMetadata = await platformAdapter.invokeBackend<Metadata>(
       "get_app_metadata",
       {
-        appPath: activeId,
+        appName: currentPlugin.name,
+        appPath: activeId
       }
     );
 
     setAppMetadata(appMetadata);
-  }, [activeId]);
+  }, [activeId, currentPlugin]);
 
   const metadata = useMemo(() => {
     if (!appMetadata) return [];
diff --git a/src/components/Settings/Extensions/index.tsx b/src/components/Settings/Extensions/index.tsx
@@ -45,7 +45,7 @@ export interface Plugin {
   onEnabledChange?: (enabled: boolean) => void;
 }
 
-interface ExtensionsContextType {
+export interface ExtensionsContextType {
   plugins: Plugin[];
   setPlugins: Dispatch<SetStateAction<Plugin[]>>;
   activeId?: string;

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ export interface Plugin {`
`45`	`45`	`onEnabledChange?: (enabled: boolean) => void;`
`46`	`46`	`}`
`47`	`47`
`48`		`-interface ExtensionsContextType {`
	`48`	`+export interface ExtensionsContextType {`
`49`	`49`	`plugins: Plugin[];`
`50`	`50`	`setPlugins: Dispatch<SetStateAction<Plugin[]>>;`
`51`	`51`	`activeId?: string;`