Skip to content

add extra info when show index detail#851

Merged
JinHai-CN merged 2 commits intoinfiniflow:mainfrom
morphes1995:tbl_index_info
Mar 22, 2024
Merged

add extra info when show index detail#851
JinHai-CN merged 2 commits intoinfiniflow:mainfrom
morphes1995:tbl_index_info

Conversation

@morphes1995
Copy link
Copy Markdown
Contributor

@morphes1995 morphes1995 commented Mar 21, 2024

What problem does this PR solve?

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Issue link:#779

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Test cases
  • Python SDK impacted, Need to update PyPI
  • Other (please describe):

@JinHai-CN JinHai-CN added the ci PR can be test label Mar 22, 2024
@JinHai-CN
Copy link
Copy Markdown
Contributor

JinHai-CN commented Mar 22, 2024

@morphes1995
thrift_server.cpp:1134, the result row count will be validated. This part is also need to update.

@morphes1995
Copy link
Copy Markdown
Contributor Author

morphes1995 commented Mar 22, 2024

@morphes1995 thrift_server.cpp:1134, the result row count will be validated. This part is also need to update.

ok

JinHai-CN
JinHai-CN reviewed Mar 22, 2024
View reviewed changes
Comment thread python/infinity/remote_thrift/infinity_thrift_rpc/infinity.thrift Outdated
JinHai-CN
JinHai-CN requested changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@JinHai-CN JinHai-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thrift IDL file need to update

@morphes1995
Copy link
Copy Markdown
Contributor Author

morphes1995 commented Mar 22, 2024

thrift IDL file need to update

ok ,i will remove index_info fields in ShowIndexResponse in infinity.thrift. Should index_info in TableIndexInfo also be removed ?

@JinHai-CN
Copy link
Copy Markdown
Contributor

JinHai-CN commented Mar 22, 2024

TableIndexInfo

Yes, please also remove it.

@morphes1995
add extra info when show index detail
6811fc2 
Signed-off-by: morphes1995 <morphes1995@gmail.com>
@morphes1995 morphes1995 requested a review from JinHai-CN March 22, 2024 11:40
@JinHai-CN JinHai-CN merged commit 4045efc into infiniflow:main Mar 22, 2024
@JinHai-CN JinHai-CN mentioned this pull request Mar 22, 2024
Closed
23 tasks
@morphes1995 morphes1995 deleted the tbl_index_info branch April 1, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JinHai-CN JinHai-CN JinHai-CN approved these changes

Assignees

No one assigned

Labels

ci PR can be test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@morphes1995 @JinHai-CN