Refactor transaction handling and update index management#435
Merged
JinHai-CN merged 4 commits intoinfiniflow:mainfrom Jan 10, 2024
Merged
Refactor transaction handling and update index management#435JinHai-CN merged 4 commits intoinfiniflow:mainfrom
JinHai-CN merged 4 commits intoinfiniflow:mainfrom
Conversation
This commit involves several updates to improve the handling of indexes and exceptions in database transactions. These updates range from enhancing transaction methods such as SaveIndexFile and PhysicalCreateIndexFinish for better error management, to improving storage efficiency through replacing WriteIndexFile function with WriteIndexToMemory. An enhancement to the transaction module for more accurate and efficient checking for existing keys has been also implemented.
2 tasks
This change refactors `logical_planner.cpp` to instantiate `base_index_ptr` within the loop, thereby improving scope control and possibly reducing memory usage. Moreover, it aligns with the good programming practice of declaring variables in the smallest meaningful scope.
JinHai-CN
reviewed
Jan 10, 2024
JinHai-CN
reviewed
Jan 10, 2024
JinHai-CN
reviewed
Jan 10, 2024
JinHai-CN
reviewed
Jan 10, 2024
The BooleanT type has been replaced with bool in several places throughout multiple source files. This promotes consistency and improves readability, aligning more closely to standard C++ conventions. Changes have been applied in methods dealing with transactions, index creation, and memory management.
JinHai-CN
approved these changes
Jan 10, 2024
Contributor
|
@mergify queue |
🟠 Waiting for conditions to matchDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This commit involves several updates to improve the handling of indexes and exceptions in database transactions. These updates range from enhancing transaction methods such as SaveIndexFile and PhysicalCreateIndexFinish for better error management, to improving storage efficiency through replacing WriteIndexFile function with WriteIndexToMemory. An enhancement to the transaction module for more accurate and efficient checking for existing keys has been also implemented.
Issue link:
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer