[Feature] Add step-level batch summary tracing (PR #3)#22
Merged
Conversation
Implements step-level observability with probabilistic sampling: - CLI flags: --step-tracing-enabled, --step-tracing-sample-rate - Emits batch summary events per sampled scheduler step - 16 attributes: queue depths, batch composition, token counts, KV metrics - O(n) complexity, failure-safe, disabled by default - 9 comprehensive tests, zero regressions (111/111 tests pass) Fixes applied based on review: - Fixed O(n²) → O(n) complexity with dict-based lookup - Moved emission before _update_after_schedule() for spec compliance - Removed dead code, explicit endpoint handling, gated timestamp capture - Documented test assumptions for spec decode compatibility Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements PR #3 from STEP_TRACING_PR_PLAN.md
Summary
Step-level observability with probabilistic sampling for vLLM scheduler.
Features
--step-tracing-enabled,--step-tracing-sample-ratescheduler_stepsspan withstep.BATCH_SUMMARYeventsTesting
Performance
Review Fixes Applied
Files Changed
🤖 Generated with Claude Code