Journey Tracing: Complete Implementation (PRs #0-#9) + Regression Audit#18
Merged
Journey Tracing: Complete Implementation (PRs #0-#9) + Regression Audit#18
Conversation
Address review feedback on journey tracing documentation: - Fix PR count: clarify 10 PRs total (PR #0 prerequisite + PRs #1-#9) - Correct test counts: 88 new tests (was inconsistently stated as 27+/45+) - Add event naming clarification (api.ARRIVED, journey.QUEUED prefixes) - Fix PR #6 streaming snippet to show finalize before yield [DONE] - Label overhead numbers as ballpark estimates - Clarify time domain usage (monotonic vs epoch, seconds vs nanoseconds) - Explain trace context propagation (HTTP headers vs internal dict) - Document error flow edge cases (truncated core events on early abort) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove two failing tests that reference the legacy journey event buffering system removed in PR #9 (commit 1d9b9f3): - test_no_events_when_span_none: Referenced _journey_events_buffer_by_client - test_legacy_buffering_still_works: Tested parallel buffering (no longer exists) These tests validated the legacy buffering pathway that was intentionally removed. Comprehensive coverage of the new span-based tracing exists in tests/v1/core/test_pr9_no_buffering.py (16 tests, 337 lines). Add REGRESSION_AUDIT_REPORT.md documenting comprehensive regression analysis from v0.0.1 to HEAD: - 42 files changed analyzed (10,824 insertions, 1,074 deletions) - All production code paths verified safe - Zero regressions to existing functionality - Proper backward compatibility maintained - OTEL imports optional and safe - Metrics work independently of tracing Test Results: 99 passed (all non-journey scheduler tests) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the journey tracing dual-stream architecture implementation across 10 PRs (PR #0 prerequisite + PRs #1-#9), including comprehensive regression audit and documentation.
What's Included
Implementation (PRs #0-#9)
Documentation & Quality
JOURNEY_TRACING.md)JOURNEY_TRACING_PR_PLAN.md)CLAUDE.md)REGRESSION_AUDIT_REPORT.md)Architecture
Dual-Stream Design:
llm_request) track end-to-end request lifecyclellm_core) track scheduler-level processingTesting
Comprehensive Test Coverage:
Regression Audit Results
Verdict: ✅ NO PRODUCTION REGRESSIONS FOUND
Verified Safe:
Changes Analyzed:
Key Features
--enable-journey-tracing)Usage
Breaking Changes
None - Fully backward compatible:
false)Files Changed
Core Implementation:
vllm/v1/core/sched/scheduler.py(+467 lines)vllm/entrypoints/openai/chat_completion/serving.py(major refactor)vllm/entrypoints/openai/engine/serving.py(+265 lines)vllm/tracing.py(+49 lines)vllm/config/observability.py(+6 lines)Tests:
Documentation:
JOURNEY_TRACING.md(623 lines) - End-user guideJOURNEY_TRACING_PR_PLAN.md(2,226 lines) - Implementation planREGRESSION_AUDIT_REPORT.md(530 lines) - Audit resultsCLAUDE.md(397 lines) - Repository guideReview Focus
Related
🤖 Generated with Claude Code