@claude /review

Claude finished @edenreich's task —— View job

PR Review: Rename A2A CRD to Agent

I've completed a comprehensive review of this major refactoring that renames the A2A (Agent-to-Agent) CRD to simply "Agent".

✅ Strengths

1. API Design Improvement: The rename from A2A to Agent significantly improves usability - kubectl get agents is much more intuitive than kubectl get a2as

2. Comprehensive Refactoring: The rename is thorough across the codebase:

   • API types properly renamed (api/v1alpha1/agent_types.go)
   • Controller implementation updated (internal/controller/agent_controller.go)
   • RBAC permissions correctly updated
   • CRDs and manifests regenerated
   • Examples updated with proper resource definitions

3. Proper Test Coverage: Added new agent_controller_test.go with appropriate Ginkgo-style tests that verify deployment and service creation

4. Clean Code Structure: The controller follows good patterns with proper error handling, retry logic, and conflict resolution

⚠️ Critical Issues

Major Inconsistency in Gateway Integration

The most significant issue is that while the Agent CRD was renamed, the Gateway CRD still references the old A2A naming throughout:

In api/v1alpha1/gateway_types.go:184:

// A2A (Agent-to-Agent) configuration  
A2A *A2AServersSpec `json:"a2a,omitempty"`

In internal/controller/gateway_controller.go:508-520:

if gateway.Spec.A2A != nil && gateway.Spec.A2A.Enabled {
    envVars = append(envVars,
        corev1.EnvVar{
            Name:  "A2A_ENABLE", 
            Value: fmt.Sprintf("%t", gateway.Spec.A2A.Enabled),
        },
        // ... more A2A environment variables

This creates a confusing situation where:

• Users create Agent resources with kubectl get agents
• But Gateway specs still reference A2A configuration
• Environment variables are still prefixed with A2A_

🔧 Recommendations

1. Complete the Gateway Rename (High Priority)

The Gateway CRD should be updated to use agents instead of a2a:

• Rename A2A *A2AServersSpec to Agents *AgentServersSpec in gateway_types.go
• Update environment variable names from A2A_* to AGENT_*
• Update all related struct names (A2AServersSpec → AgentServersSpec, etc.)

2. Migration Documentation

Since this is a breaking change, consider:

• Adding migration scripts or instructions
• Versioning the API to support both during transition
• Clear documentation about the breaking changes

3. Consider Semantic Versioning

This level of API change might warrant a version bump (e.g., v1alpha2) to signal the breaking nature.

📋 Minor Issues

1. Comment Inconsistency: Some comments still reference "A2A (Agent-to-Agent)" when they should just say "Agent"

2. Test Coverage Gap: The deleted a2a_controller_test.go had 143 lines vs new agent_controller_test.go with 106 lines - verify all test scenarios are covered

Overall Assessment

This is a well-executed refactoring that improves the API's usability, but it's incomplete. The Gateway integration still uses A2A terminology, creating a confusing mixed state. The PR should either:

1. Complete the rename by updating Gateway CRD and controller references
2. Split the work and clearly document that this is Phase 1 of a larger rename effort

Recommendation: Complete the Gateway integration updates before merging to avoid confusion for users.

I left the Gateway manifest calling it A2A because that's the name of the protocol a user intending to use, it connects to other agents (so I'm just renaming the A2A kind resource to Agent because it feels more natural - internally the A2A kind resource can use MCP or Standard Tool-Use) but what's make an Agent is the A2A Server. They are only connecting via A2A.

TODO - I need to update the Inference Gateway Service Discovery to look for Agent CRD instead of A2A.

🎉 This PR is included in version 0.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀