Skip to content

feat(a2a): Add automatic pod restart on configuration changes#20

Merged
edenreich merged 5 commits intomainfrom
claude/issue-18-20250728-1252
Jul 28, 2025
Merged

feat(a2a): Add automatic pod restart on configuration changes#20
edenreich merged 5 commits intomainfrom
claude/issue-18-20250728-1252

Conversation

@edenreich
Copy link
Copy Markdown
Collaborator

Fixes ##18

Implement comprehensive deployment update mechanism for A2A controller:

  • Enhanced buildA2ADeployment to incorporate all A2A spec configuration
  • Added reconcileDeployment for proper deployment reconciliation
  • Added updateDeploymentIfNeeded with deep comparison for config changes
  • Added required RBAC permissions for deployment management
  • Auto-restart mechanism triggers pod restarts when any configuration changes

Generated with Claude Code

Implement comprehensive deployment update mechanism for A2A controller:

- Enhanced buildA2ADeployment to incorporate all A2A spec configuration
- Added reconcileDeployment for proper deployment reconciliation
- Added updateDeploymentIfNeeded with deep comparison for config changes
- Added required RBAC permissions for deployment management
- Auto-restart mechanism triggers pod restarts when any configuration changes

Fixes automatic restart issue when applying new A2A configurations.

Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>
@edenreich
Copy link
Copy Markdown
Collaborator Author

@claude The CI is failing - can you fix it?

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jul 28, 2025

Claude finished @edenreich's task —— View job


Todo List

  • Investigate CI failure details
  • Analyze the modified A2A controller code
  • Install project dependencies and set up environment
  • Reproduce and identify failing tests locally
  • Fix the code issues causing test failures
  • Run linting and testing as per development workflow
  • Commit fixes to the PR branch

CI Issue Found & Fixed ✅

The linter was failing with unparam errors for unused parameters in two functions:

  1. updateDeploymentIfNeeded - a2a parameter was unused
  2. createOrUpdateDeployment - a2a parameter was unused

Changes Made

  • Removed unused a2a parameter from updateDeploymentIfNeeded function signature (line 373)
  • Removed unused a2a parameter from createOrUpdateDeployment function signature (line 354)
  • Updated both call sites to not pass the unused parameters

Verification

✅ Linting: task lint - 0 issues
✅ Compilation: go build - successful
✅ Code quality: go vet and go fmt - no issues

Summary

Successfully fixed the CI linter failures by removing genuinely unused parameters. The changes are minimal, safe, and maintain all existing functionality while resolving the unparam errors that were blocking the build.

Commit: 8fc0143 - Fix(a2a): Remove unused parameters to resolve linter errors

claude bot and others added 4 commits July 28, 2025 13:09
Remove unused 'a2a' parameters from updateDeploymentIfNeeded and 
createOrUpdateDeployment functions that were causing unparam linter failures.

Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>
…ariable setup

Signed-off-by: Eden Reich <eden.reich@gmail.com>
@edenreich edenreich merged commit 307fee2 into main Jul 28, 2025
5 checks passed
@edenreich edenreich deleted the claude/issue-18-20250728-1252 branch July 28, 2025 22:14
@edenreich edenreich linked an issue Jul 28, 2025 that may be closed by this pull request
ig-semantic-release-bot bot added a commit that referenced this pull request Jul 28, 2025
## [0.11.0](v0.10.0...v0.11.0) (2025-07-28)

### ✨ Features

* **a2a:** Add automatic pod restart on configuration changes ([#20](#20)) ([307fee2](307fee2))

### ♻️ Improvements

* **a2a:** Simplify Service Discovery to use CRD-based approach ([#21](#21)) ([121e33b](121e33b)), closes [#19](#19)

### 👷 CI

* Consolidate linting and build processes into a single CI workflow ([#22](#22)) ([f4591e9](f4591e9))

### 📚 Documentation

* **examples:** Add Google provider support ([#23](#23)) ([879e762](879e762)), closes [#17](#17)
@ig-semantic-release-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add automatic pod restarts when configuration changes

1 participant