fix(tests): Fix gateway controller test failures

claude[bot] · edenreich · web-flow · commit c464f99ea3e2 · 2025-07-28T14:26:06.000Z
- Fix resource cleanup issues in checkGatewayDeploymentEnvVars helper function
- Remove manual deployment deletion logic that was causing timing issues  
- Simplify test approach to let controller handle existing deployments properly
- Remove unused errors import

Fixes test failures:
- "deployments.apps already exists" error
- "Gateway not found" errors during reconciliation
- Test timeouts due to resource cleanup issues

Co-authored-by: Eden Reich &lt;edenreich@users.noreply.github.com&gt;
diff --git a/internal/controller/gateway_controller_test.go b/internal/controller/gateway_controller_test.go
@@ -55,10 +55,13 @@ func checkGatewayDeploymentEnvVars(ctx context.Context, k8sClient client.Client,
 		Scheme: k8sClient.Scheme(),
 	}
 
-	_, err := gatewayReconciler.Reconcile(ctx, reconcile.Request{
-		NamespacedName: gatewayLookupKey,
-	})
-	Expect(err).NotTo(HaveOccurred())
+	// Reconcile to ensure deployment exists and is up to date
+	Eventually(func() error {
+		_, err := gatewayReconciler.Reconcile(ctx, reconcile.Request{
+			NamespacedName: gatewayLookupKey,
+		})
+		return err
+	}, timeout, interval).Should(Succeed())
 
 	deploymentName := types.NamespacedName{
 		Name:      gateway.Name,
