Skip to content

Commit 78ed5c0

Browse files
fix(a2a): Rename A2A_SERVICE_DISCOVERY_ENABLED to A2A_SERVICE_DISCOVERY_ENABLE (#27)
The Inference Gateway expects A2A_SERVICE_DISCOVERY_ENABLE, not A2A_SERVICE_DISCOVERY_ENABLED. Updated the environment variable name in the controller and tests to match the expected format. Since the Inference Gartway using the present naming convention will keep it like this: A2A_SERVICE_DISCOVERY_ENABLE - IDK maybe will add the past convention in future versions - haven't consolidate it yet. Closes #25 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Eden Reich <edenreich@users.noreply.github.com> Signed-off-by: Eden Reich <eden.reich@gmail.com>
1 parent eda42e4 commit 78ed5c0

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

internal/controller/gateway_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ func (r *GatewayReconciler) buildContainer(ctx context.Context, gateway *corev1a
523523

524524
envVars = append(envVars,
525525
corev1.EnvVar{
526-
Name: "A2A_SERVICE_DISCOVERY_ENABLED",
526+
Name: "A2A_SERVICE_DISCOVERY_ENABLE",
527527
Value: fmt.Sprintf("%t", gateway.Spec.A2A.ServiceDiscovery.Enabled),
528528
},
529529
corev1.EnvVar{

internal/controller/gateway_controller_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ var _ = Describe("Gateway controller", func() {
532532
{Name: "A2A_EXPOSE", Value: "false"},
533533
{Name: "A2A_AGENTS", Value: ""},
534534
{Name: "A2A_CLIENT_TIMEOUT", Value: "5s"},
535-
{Name: "A2A_SERVICE_DISCOVERY_ENABLED", Value: "true"},
535+
{Name: "A2A_SERVICE_DISCOVERY_ENABLE", Value: "true"},
536536
{Name: "A2A_SERVICE_DISCOVERY_NAMESPACE", Value: "test-namespace"},
537537
{Name: "A2A_SERVICE_DISCOVERY_ENDPOINTS", Value: ""},
538538
{Name: "A2A_SERVICE_DISCOVERY_POLLING_INTERVAL", Value: "60s"},
@@ -571,7 +571,7 @@ var _ = Describe("Gateway controller", func() {
571571
{Name: "A2A_EXPOSE", Value: "false"},
572572
{Name: "A2A_AGENTS", Value: ""},
573573
{Name: "A2A_CLIENT_TIMEOUT", Value: "5s"},
574-
{Name: "A2A_SERVICE_DISCOVERY_ENABLED", Value: "true"},
574+
{Name: "A2A_SERVICE_DISCOVERY_ENABLE", Value: "true"},
575575
{Name: "A2A_SERVICE_DISCOVERY_NAMESPACE", Value: "default"},
576576
{Name: "A2A_SERVICE_DISCOVERY_ENDPOINTS", Value: ""},
577577
{Name: "A2A_SERVICE_DISCOVERY_POLLING_INTERVAL", Value: "30s"},

0 commit comments

Comments
 (0)