Introduce --logger-text option to enforce text logger file path#2438
Introduce --logger-text option to enforce text logger file path#2438maks-rafalko merged 1 commit intoinfection:masterfrom
--logger-text option to enforce text logger file path#2438Conversation
It's tested here I guess: infection/tests/phpunit/Configuration/ConfigurationFactoryTest.php Lines 355 to 389 in 242785d You can create something similar. It's one of the hardest tests in Infection so sorry in advance 🤣
absolutely makes sense Regarding 100% MSI required here for PRs, feel free to skip this if it's too hard, we will merge anyway (I don't want to force you writing tests for the places covered badly previously). |
a937eb5 to
afd3b11
Compare
|
Thanks for the hint! I shamefully copy-paster these tests, but that should be enough. 😊 |
|
could you please fix https://github.com/infection/infection/actions/runs/18403064509/job/52436622828?pr=2438#step:7:48? And we are good to go |
Allows the usage of `--logger-text` option when running Infection, to override the "logs.text" option from the configuration file.
afd3b11 to
1358dd2
Compare
|
Thank you @romm 👍 |
|
That was fast! Thank you 😊 |
Allows the usage of
--logger-textoption when running Infection, to override the "logs.text" option from the configuration file.This PR:
--logger-textoption site#285I'm coming from https://github.com/phpstan/phpstan-doctrine/pull/686/files#r2416912180 — I like to work with a text log file when running Infection locally, however it makes sense to use
php://stdoutwhen running it in the pipeline. Adding this console option allows to override the option set in the configuration file.I did not find an existing test for the
--logger-htmloption, to create a similar test for this newly added option. What should I do?If the PR is ok for you, I'll add a PR to update the documentation.