Skip to content

PHPStan integration: drop --fail-without-result-cache#2429

Merged
maks-rafalko merged 1 commit intoinfection:masterfrom
staabm:stan-dr
Oct 7, 2025
Merged

PHPStan integration: drop --fail-without-result-cache#2429
maks-rafalko merged 1 commit intoinfection:masterfrom
staabm:stan-dr

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Oct 7, 2025

drop --fail-without-result-cache which does not work when a project contains PHPStan extension classes and those get mutated. these will not create a cache hit and emit the following warning:

Result cache not used because extension file /Users/m.staab/dvl/phpstan-doctrine/src/Rules/Doctrine/ORM/QueryBuilderDqlRule.php hash does not match.

background story: see phpstan/phpstan-doctrine#686 (comment) and following

@staabm staabm changed the title PHPStan integration: drop --fail-without-result-cache PHPStan integration: drop --fail-without-result-cache Oct 7, 2025
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@maks-rafalko maks-rafalko marked this pull request as ready for review October 7, 2025 12:15
@maks-rafalko maks-rafalko enabled auto-merge (squash) October 7, 2025 12:15
@maks-rafalko maks-rafalko dismissed github-actions[bot]’s stale review October 7, 2025 12:15

tests have been updated

@maks-rafalko maks-rafalko added the TestFramework / PHPstan Issues related to the PHPStan adapter. label Oct 7, 2025
@maks-rafalko maks-rafalko merged commit fb06b33 into infection:master Oct 7, 2025
57 checks passed
@staabm staabm deleted the stan-dr branch October 7, 2025 12:26
@maks-rafalko
Copy link
Copy Markdown
Member

maks-rafalko commented Oct 7, 2025

thank you @staabm

Released https://github.com/infection/infection/releases/tag/0.31.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TestFramework / PHPstan Issues related to the PHPStan adapter.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants