Skip to content

Refactor InitialConfigBuilder#1378

Merged
sanmai merged 1 commit intoinfection:masterfrom
sanmai:pr/2020-10/refactor-InitialConfigBuilderTest
Oct 27, 2020
Merged

Refactor InitialConfigBuilder#1378
sanmai merged 1 commit intoinfection:masterfrom
sanmai:pr/2020-10/refactor-InitialConfigBuilderTest

Conversation

@sanmai
Copy link
Copy Markdown
Member

@sanmai sanmai commented Oct 27, 2020 •
edited
Loading

This PR:

  • Adds heuristics to detect used PHPUnit configuration format.
  • Add a method to update PHPUnit configuration with appropriate coverage whitelist/include directives.
  • Fixes PHPUnit 9.3 compatibility issue #1283 to the point we're using Infection with the newest PHPUnit configuration.

@sanmai sanmai added this to the PHPUnit 9.3-ready milestone Oct 27, 2020
@sanmai sanmai requested a review from maks-rafalko October 27, 2020 10:05
@sanmai sanmai marked this pull request as ready for review October 27, 2020 10:05
@sanmai sanmai force-pushed the pr/2020-10/refactor-InitialConfigBuilderTest branch from 763d842 to 1f5731e Compare October 27, 2020 10:06
@sanmai sanmai force-pushed the pr/2020-10/refactor-InitialConfigBuilderTest branch from 1f5731e to c009304 Compare October 27, 2020 10:09
@sanmai sanmai changed the title Refactor InitialConfigBuilderTest Introduce XmlConfigurationVersionProvider Oct 27, 2020
@sanmai sanmai changed the title Introduce XmlConfigurationVersionProvider Refactor InitialConfigBuilder Oct 27, 2020
maks-rafalko
maks-rafalko approved these changes Oct 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sanmai
Copy link
Copy Markdown
Member Author

sanmai commented Oct 27, 2020

Great! Release-worthy, what do you think?

@maks-rafalko
Copy link
Copy Markdown
Member

maks-rafalko commented Oct 27, 2020

Sure, will do it tonight

@sanmai sanmai merged commit 3119045 into infection:master Oct 27, 2020
@sanmai sanmai deleted the pr/2020-10/refactor-InitialConfigBuilderTest branch October 27, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees

No one assigned

Labels

Bugfix Feature

Projects

None yet

Milestone

PHPUnit 9.3-ready

Development

Successfully merging this pull request may close these issues.

PHPUnit 9.3 compatibility issue

2 participants

@sanmai @maks-rafalko