Add notarize cargo feature and fix missing dependency feature#78
Closed
melvyn2 wants to merge 2 commits into
Closed
Add notarize cargo feature and fix missing dependency feature#78melvyn2 wants to merge 2 commits into
notarize cargo feature and fix missing dependency feature#78melvyn2 wants to merge 2 commits into
Conversation
indygreg
approved these changes
Jun 3, 2023
indygreg
left a comment
Owner
There was a problem hiding this comment.
Looks great! Thanks for doing this refactor.
I'm going to cherry pick this locally since I've already staged a bunch of crate updates and there are some minor merge conflicts in the Cargo files.
Contributor
|
This is a great step in reducing the size of this dependency. We only use the code signing crate for ad-hoc signing so this helps a lot. Would it be possible to publish a new release so we can start using this? @indygreg |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #70 slightly, I broke out dependencies needed only for notarization, enabled by default as to not break existing behavior.
Also added the necessary
pkcs8feature for thepkcs1, which only broke aftercargo update(seems like a semver violation but I didn't track down the upstream change).