Fix support for ADHOC app bundle signing with frameworks#44
Conversation
indygreg
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I think this seems reasonable.
Do you have steps to reproduce the previous failure? I'd like to verify behavior locally before merging this.
(Also, I'm starting to regret not having better test coverage for bundle signing - this is easily the most nuanced part of the code base!)
Before this, codesign would error with "the sealed resource directory is invalid". This add a new codepath when no code requirements has been set that will enforce a requirement presence and ensure that appropriate cdhashes are present for the given file.
I made a simple dummy reproducer that I attached below. |
indygreg
left a comment
There was a problem hiding this comment.
I think this looks pretty good.
Sorry for the high review latency.
I'm going to clean this up a little locally and push a lightly modified version to main.
Thank you for the contribution!
Before this, codesign would error with "the sealed resource directory is invalid".
This add a new codepath when no code requirements has been set that will enforce a requirement presence and ensure that appropriate cdhashes are present for the given file.