apple-codesign: honor verbose level to set logging level#162
Closed
reckenrode wants to merge 1 commit into
Closed
Conversation
Using `from_env` was only setting the logging level from the environment. Setting `filter_level` then using `parse_default_env` sets the logging level based on the verbosity level while still honoring the `RUST_LOG` environment variable.
13 tasks
indygreg
approved these changes
Nov 2, 2024
indygreg
left a comment
Owner
There was a problem hiding this comment.
Hmmm. I wonder how I got this wrong, since I'm pretty sure I copied the code from the env_logger documentation / examples. Regardless, the new code looks correct. Thanks for the fix!
I'll rebase and push locally so the PR will be marked as closed instead of merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While updating rcodesign in nixpkgs, I ran into failing tests with cli_tests. It seems the verbosity flag used by the tests is not being honored. With this patch, verbosity level sets the default logging level, which can be overriden with the
RUST_LOGenvironment variable.