Fix q=source to return valid MF2 JSON for all properties#312
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the micropub_get_mf2() function to ensure all MF2 property values are returned as arrays, as required by the Microformats2 specification. This addresses issue #242 where the q=source query was returning non-compliant MF2 JSON for certain properties.
Changes:
- Added validation to skip empty string values from post meta, as they indicate unset properties
- Added logic to wrap non-array values in arrays to ensure MF2 compliance
- Ensures consistent array structure for all MF2 properties retrieved from post meta
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ensure all MF2 property values are arrays as required by the spec. Skip empty string values (unset properties) and wrap non-array values in arrays. Fixes #242
495e0cb to
dddd70d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #242