Skip to content

Add IndieAuth as Plugin Dependency#299

Merged
pfefferle merged 1 commit intotrunkfrom
add/plugin-dependency
Mar 13, 2024
Merged

Add IndieAuth as Plugin Dependency#299
pfefferle merged 1 commit intotrunkfrom
add/plugin-dependency

Conversation

@pfefferle
Copy link
Copy Markdown
Member

@pfefferle pfefferle commented Mar 13, 2024

@pfefferle pfefferle requested review from dshanske and snarfed March 13, 2024 14:27
Copy link
Copy Markdown
Member

@snarfed snarfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pfefferle pfefferle merged commit c1ba163 into trunk Mar 13, 2024
@pfefferle pfefferle deleted the add/plugin-dependency branch March 13, 2024 15:46
@dshanske
Copy link
Copy Markdown
Member

I was going to ask about backcompat, but I think we have it covered.

@pfefferle
Copy link
Copy Markdown
Member Author

What do you mean with backcompat? It will be ignored by all versions below 6.5, so it should be fine.

@dshanske
Copy link
Copy Markdown
Member

What do you mean with backcompat? It will be ignored by all versions below 6.5, so it should be fine.

Yes, and I'm still checking for the presence of the plugin class, but I'm wondering about the long-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants