Opt-in mutable access on IndexSet, release 2.2.6#323
Merged
cuviper merged 4 commits intoindexmap-rs:masterfrom Mar 23, 2024
Merged
Opt-in mutable access on IndexSet, release 2.2.6#323cuviper merged 4 commits intoindexmap-rs:masterfrom
cuviper merged 4 commits intoindexmap-rs:masterfrom
Conversation
Member
Author
|
@Morganamilo would this work for you? |
|
This is what I was looking for thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
set::MutableValuesas an opt-in trait for accessingIndexSetvalues by mutable reference, akin tomap::MutableKeys. The implementation simply forwards to the map implementation while discarding the()inner "value".Unlike
IndexMap,IndexSetdoesn't have regularget_full_mutorget_index_mutmethods, so the "2" suffix here isn't really necessary, but I thought it might be better to stay consistent withMutableKeyson that.Closes #322