Conversation
|
tests keeps failing because the ui is changed, the change is only made to the header (title of page) comparisonold ui
new ui all interfaces (no -i flag)
new ui with 1 interface (-i flag)
|
We use insta for most of our tests. I recommend installing the companion tool cargo-insta, then you can use P.S. and don't worry if there are spontaneous test failures in CI for Windows/MacOS. These are known issues and are being worked on. As long as CI passes for Ubuntu, you should be good to go. |
|
Looks alright now. There are a few small things I'l touch up and then we'll merge. |
src/display/ui.rs
Outdated
| pub fn update_interface_name(&mut self, interface_name: Option<String>) { | ||
| self.state.interface_name = interface_name; | ||
| } |
There was a problem hiding this comment.
This kind of trivial setter method is very "Java-esque" and creates a lot of (frankly unnecessary) boilerplate code. We typically don't do this in Rust.
src/main.rs
Outdated
| let mut ui = ui.lock().unwrap(); | ||
| let paused = paused.load(Ordering::SeqCst); | ||
| let ui_offset = ui_offset.load(Ordering::SeqCst); | ||
| ui.update_interface_name(opts.interface.clone()); |
There was a problem hiding this comment.
This doesn't need to run in the main loop.
|
Changelog detection in CI is not working due to an unhandled edge case, which was fixed in #342. Merging. |
fixing old commits
solves issue #37 to some extent
unfortunately i wasn't able to figure out how to add the network interface type along side it's name