Skip to content

Table formatting logic overhaul#305

Merged
cyqsimon merged 10 commits intomainfrom
table-layout-rewrite
Oct 19, 2023
Merged

Table formatting logic overhaul#305
cyqsimon merged 10 commits intomainfrom
table-layout-rewrite

Conversation

@cyqsimon
Copy link
Copy Markdown
Collaborator

@cyqsimon cyqsimon commented Oct 16, 2023

Will fix #214. Will fix #276. Will fix #307.

  • Columns auto-expand and auto-shrink proportionally
  • Setting which columns to display with a given width constraint is done on a per-table basis
  • Necessary boilerplate to allow tables with more (or fewer) columns in the future
  • Optimise layout cutoff widths
  • Figure out what to do with the UI tests (see Fix flaky tests on the ci #303)

@cyqsimon
Copy link
Copy Markdown
Collaborator Author

Rebased.

@cyqsimon
Copy link
Copy Markdown
Collaborator Author

Rebased.

- Columns now auto-expand and auto-shrink proportionally
- Data column selection logic is now set per-table
- Necessary boilerplate added to allow tables with more (or fewer) columns in the future
- These values are pretty much arbitrary. I'm open to further optimising them in the future.
@cyqsimon cyqsimon force-pushed the table-layout-rewrite branch from 3676895 to 6d9dae7 Compare October 17, 2023 11:59
@cyqsimon
Copy link
Copy Markdown
Collaborator Author

Rebased.

@cyqsimon cyqsimon marked this pull request as ready for review October 19, 2023 08:52
@cyqsimon cyqsimon merged commit 0c4987a into main Oct 19, 2023
@cyqsimon cyqsimon deleted the table-layout-rewrite branch October 20, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant