Conversation
|
This looks good to me and is probably more true to how most bandwidth is recorded, but we should probably change to the proper units as well (eg "MB" -> "MiB"). As I understand, things like MB and KB are the SI units divided just by things like Otherwise, looks like a good change! It could be extra work, but we could also have a flag for picking the units? The only reason I say that is it may be confusing if you download a |
|
That's interesting. Hum... FF and wget seem to be reporting these as {M,K}B/s. Running some manual tests, it seems to me* that we match both of these. So do you think this is a "mistake" on their part, or just an omission to make things simple? *hard to be 100% sure because we're averaging our reporting over 3 seconds |
|
Did some tests with I dunno about the flag. I want to try to avoid adding more flags tbh. Maybe if someone specifically needs the distinction? |
|
Haha, upon looking into this further, it seems like a bit of a mess. From what I can gather, FF uses the powers-of-two even when the operating system (like Linux and MacOS, I believe) use the SI powers-of-ten convention. Here is a bug report about that and an ancient, still open one on a similar topic. I think though, that this is the standard the Unixes have settled on for the most part? And yeah, on second thought, it's probably not worth the flag. I think that moving to the "ibi" units is nice just to be totally unambiguous :) |
|
Alright, changed everything to ibis. :) Going to merge this. Thanks for the valuable input! |
This fix improves the accuracy presentation by dividing the bytes per second by the right divisions (eg.
1_048_576instead of1_000_000for MB).