Skip to content

docs: add modules to global polyfills usage#157

Merged
imranbarbhuiya merged 2 commits intoimranbarbhuiya:mainfrom
markdalgleish:globals-docs
Aug 28, 2023
Merged

docs: add modules to global polyfills usage#157
imranbarbhuiya merged 2 commits intoimranbarbhuiya:mainfrom
markdalgleish:globals-docs

Conversation

@markdalgleish
Copy link
Contributor

I noticed the docs are incomplete for global polyfills since they depend on the corresponding modules being present.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@imranbarbhuiya
Copy link
Owner

adding code in the same code block might confuse users who arent using modules option so wdyt of cc92061 change?

@markdalgleish
Copy link
Contributor Author

Ah yep, that's a good point. LGTM 👍

@imranbarbhuiya imranbarbhuiya merged commit 54e8d46 into imranbarbhuiya:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants