test: ensure tree-shaken modules avoid fallback#156
Merged
imranbarbhuiya merged 1 commit intoimranbarbhuiya:mainfrom Aug 28, 2023
Merged
test: ensure tree-shaken modules avoid fallback#156imranbarbhuiya merged 1 commit intoimranbarbhuiya:mainfrom
imranbarbhuiya merged 1 commit intoimranbarbhuiya:mainfrom
Conversation
imranbarbhuiya
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the fallback fixture so that we also check that tree-shaken modules that would otherwise have triggered the error fallback are not present in the error message. This would be pretty disruptive if this regressed in a Remix context so I thought it'd be a good idea to ensure this can't slip through.
Status and versioning classification: