feat: support custom error formatting#153
Merged
imranbarbhuiya merged 1 commit intoimranbarbhuiya:mainfrom Aug 25, 2023
Merged
Conversation
c2aec95 to
597217c
Compare
imranbarbhuiya
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
formatErroroption so that consumers can customise the error messages when anerrormodule is detected. This is useful in the context of a tool like Remix where we'll want to give our consumers more Remix-specific advice for how to fix the error since they don't have access to this esbuild plugin directly.I've also improved the error messaging for when a module doesn't have a polyfill available. Without this we'd end up instructing our consumers to enable the polyfill, only for the polyfill to fail.
Status and versioning classification: