fix: cache usage of modern-node-polyfills API#115
Merged
imranbarbhuiya merged 4 commits intoimranbarbhuiya:mainfrom Jun 20, 2023
Merged
fix: cache usage of modern-node-polyfills API#115imranbarbhuiya merged 4 commits intoimranbarbhuiya:mainfrom
imranbarbhuiya merged 4 commits intoimranbarbhuiya:mainfrom
Conversation
imranbarbhuiya
approved these changes
Jun 20, 2023
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for all your hard work on this plugin :)
This plugin was recently added to Remix, replacing an older polyfills plugin, but we've found that the calls to
polyfillPathandpolyfillContentcan be quite slow, even on rebuilds. To dramatically improve build performance, this PR introduces a cache for these functions.Note that the cache stores promises rather than final values because there might be multiple instances of the plugin running at the same time, which is the case in Remix, and we want any subsequent calls to wait on the same operation.
Status and versioning classification: