This repository was archived by the owner on Oct 16, 2023. It is now read-only.
fix: Disabled blocks are no longer draggable#44
Merged
Conversation
|
A build of this branch is available at https://impress-org.github.io/givewp-next-gen/fix/draggable-disable-41 |
jonwaldstein
approved these changes
Jul 27, 2022
Contributor
jonwaldstein
left a comment
There was a problem hiding this comment.
@kjohnson great work hunting this bug down! I actually went ahead and updated this fork to use the actual react component src instead of the build file. That should make this more maintainable and readable without the baggage from the build.
Contributor
Author
|
@jonwaldstein thanks for that change - much better! |
|
A build of this branch is available at https://impress-org.github.io/givewp-next-gen/develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #41
Description
This PR forks the
BlockTypesListcomponent from@wordpress/block-editor/build/componentsso that theisDraggableprop accounts for the individual items'isDisabledprop.Visuals
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks