Map one and zero to true and false in bool expressions#290
Map one and zero to true and false in bool expressions#290thedataking wants to merge 2 commits intomasterfrom
Conversation
c5a4e52 to
7b7f4f9
Compare
|
I rebased this. It seems like a fairly straightforward bit of low-hanging fruit; we now transpile |
kkysen
left a comment
There was a problem hiding this comment.
Can we wait until the const macro changes finish merging before this? I had been working on this as well but was trying to sequence it with the overlapping const macro work, and I didn't realize you were going to work on it at the same time as me.
|
@kkysen can this land now or is it obsoleted by your work? |
kkysen
left a comment
There was a problem hiding this comment.
@kkysen can this land now or is it obsoleted by your work?
Partially. This solution as-is doesn't work anymore, because we translate true as the const true_0: c_int now. I think it might be better to make that const true_0: bool, but leave the true_0/false_0, just like we leave type uint32_t = u32 instead of using u32 directly.
No description provided.