transpile: do not allow f128::new in const contexts#1294
Merged
fw-immunant merged 2 commits intomasterfrom Jul 23, 2025
Merged
Conversation
kkysen
reviewed
Jul 22, 2025
kkysen
reviewed
Jul 22, 2025
Contributor
kkysen
left a comment
There was a problem hiding this comment.
I think the changes look good but a test would be helpful. I'm not sure if this just results in a transpiler error or just prevents using this in const macros.
a928322 to
5f9e48b
Compare
kkysen
reviewed
Jul 23, 2025
Fixes #829. This is a limitation of the f128 crate itself; if changed upstream or if we begin to translate f128 to the native Rust type, we can begin translating f128 in const contexts again.
0ab5a9b to
27973e3
Compare
disabled on macOS because f128 does not work there
27973e3 to
6d270ad
Compare
kkysen
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
long doubleconstructors not marked asconst-incompatible #829.This is a limitation of the f128 crate itself; if changed upstream or if we begin to translate f128 to the native Rust type, we can begin translating f128 in const contexts again (see #1262).